refactor(ActivityGroupMemberController, Service): 불필요한 responseDto 삭제…

… 및 명확한 리턴타입 명시 #455
kgu-clab · Aug 12, 2024 · 2541728 · 2541728
1 parent d8bdcaa
commit 2541728
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 114 deletions.
diff --git a/...n/java/page/clab/api/domain/activity/activitygroup/api/ActivityGroupMemberController.java b/...n/java/page/clab/api/domain/activity/activitygroup/api/ActivityGroupMemberController.java
@@ -19,6 +19,7 @@
 import page.clab.api.domain.activity.activitygroup.domain.ActivityGroupStatus;
 import page.clab.api.domain.activity.activitygroup.dto.param.GroupScheduleDto;
 import page.clab.api.domain.activity.activitygroup.dto.request.ApplyFormRequestDto;
+import page.clab.api.domain.activity.activitygroup.dto.response.ActivityGroupDetailResponseDto;
 import page.clab.api.domain.activity.activitygroup.dto.response.ActivityGroupResponseDto;
 import page.clab.api.domain.activity.activitygroup.dto.response.ActivityGroupStatusResponseDto;
 import page.clab.api.domain.activity.activitygroup.dto.response.GroupMemberResponseDto;
@@ -57,10 +58,10 @@ public ApiResponse<PagedResponseDto<ActivityGroupResponseDto>> getActivityGroups
     @Operation(summary = "[U] 활동 상세 조회", description = "ROLE_ANONYMOUS 이상의 권한이 필요함")
     @PreAuthorize("hasRole('USER')")
     @GetMapping("/{activityGroupId}")
-    public ApiResponse<Object> getActivityGroup(
+    public ApiResponse<ActivityGroupDetailResponseDto> getActivityGroup(
             @PathVariable(name = "activityGroupId") Long activityGroupId
     ) {
-        Object activityGroup = activityGroupMemberService.getActivityGroup(activityGroupId);
+        ActivityGroupDetailResponseDto activityGroup = activityGroupMemberService.getActivityGroup(activityGroupId);
         return ApiResponse.success(activityGroup);
     }
 

diff --git a/...a/page/clab/api/domain/activity/activitygroup/application/ActivityGroupMemberService.java b/...a/page/clab/api/domain/activity/activitygroup/application/ActivityGroupMemberService.java
@@ -25,10 +25,8 @@
 import page.clab.api.domain.activity.activitygroup.dto.request.ApplyFormRequestDto;
 import page.clab.api.domain.activity.activitygroup.dto.response.ActivityGroupBoardResponseDto;
 import page.clab.api.domain.activity.activitygroup.dto.response.ActivityGroupDetailResponseDto;
-import page.clab.api.domain.activity.activitygroup.dto.response.ActivityGroupProjectResponseDto;
 import page.clab.api.domain.activity.activitygroup.dto.response.ActivityGroupResponseDto;
 import page.clab.api.domain.activity.activitygroup.dto.response.ActivityGroupStatusResponseDto;
-import page.clab.api.domain.activity.activitygroup.dto.response.ActivityGroupStudyResponseDto;
 import page.clab.api.domain.activity.activitygroup.dto.response.GroupMemberResponseDto;
 import page.clab.api.domain.activity.activitygroup.exception.AlreadyAppliedException;
 import page.clab.api.domain.activity.activitygroup.exception.InvalidCategoryException;
@@ -61,7 +59,7 @@ public PagedResponseDto<ActivityGroupResponseDto> getActivityGroups(Pageable pag
     }
 
     @Transactional(readOnly = true)
-    public Object getActivityGroup(Long activityGroupId) {
+    public ActivityGroupDetailResponseDto getActivityGroup(Long activityGroupId) {
         ActivityGroupDetails details = activityGroupDetailsRepository.fetchActivityGroupDetails(activityGroupId);
         Member currentMember = externalRetrieveMemberUseCase.getCurrentMember();
 

diff --git a/.../clab/api/domain/activity/activitygroup/dto/response/ActivityGroupProjectResponseDto.java b/.../clab/api/domain/activity/activitygroup/dto/response/ActivityGroupProjectResponseDto.java
diff --git a/...ge/clab/api/domain/activity/activitygroup/dto/response/ActivityGroupStudyResponseDto.java b/...ge/clab/api/domain/activity/activitygroup/dto/response/ActivityGroupStudyResponseDto.java