refactor(Member): 멤버 생성 API 중복 검사 로직 최적화

kgu-clab · May 6, 2024 · 5dddfa4 · 5dddfa4
1 parent b1b4390
commit 5dddfa4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/main/java/page/clab/api/domain/member/application/MemberService.java b/src/main/java/page/clab/api/domain/member/application/MemberService.java
@@ -229,11 +229,11 @@ private void setRandomPasswordAndSendEmail(Member member) {
     }
 
     private void checkMemberUniqueness(MemberRequestDto requestDto) {
-        if (memberRepository.findById(requestDto.getId()).isPresent())
+        if (memberRepository.existsById(requestDto.getId()))
             throw new DuplicateMemberIdException("이미 사용 중인 아이디입니다.");
-        if (memberRepository.findByContact(requestDto.getContact()).isPresent())
+        if (memberRepository.existsByContact(requestDto.getContact()))
             throw new DuplicateMemberContactException("이미 사용 중인 연락처입니다.");
-        if (memberRepository.findByEmail(requestDto.getEmail()).isPresent())
+        if (memberRepository.existsByEmail(requestDto.getEmail()))
             throw new DuplicateMemberEmailException("이미 사용 중인 이메일입니다.");
     }
 

diff --git a/src/main/java/page/clab/api/domain/member/dao/MemberRepository.java b/src/main/java/page/clab/api/domain/member/dao/MemberRepository.java
@@ -12,7 +12,9 @@
 @Repository
 public interface MemberRepository extends JpaRepository<Member, String>, MemberRepositoryCustom, QuerydslPredicateExecutor<Member> {
 
-    Optional<Member> findByContact(String contact);
+    boolean existsByContact(String contact);
+
+    boolean existsByEmail(String email);
 
     Optional<Object> findByEmail(String email);