-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
댓글 조회시 대댓글 개수도 포함되도록 변경 완료 #430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
자식 댓글은 부모 댓글 안에만 포함되어야 하지만, 자식 댓글이 부모 댓글에 중복되는 현상이 있는 것 같습니다. 확인 부탁드립니다. |
숨어 있었던 버그를 잡아주셔서 감사합니다!
|
limehee
reviewed
Jul 23, 2024
...java/page/clab/api/domain/community/comment/application/service/CommentRetrievalService.java
Outdated
Show resolved
Hide resolved
src/main/java/page/clab/api/global/common/dto/PagedResponseDto.java
Outdated
Show resolved
Hide resolved
limehee
reviewed
Jul 24, 2024
...java/page/clab/api/domain/community/comment/application/service/CommentRetrievalService.java
Outdated
Show resolved
Hide resolved
mingmingmon
approved these changes
Jul 24, 2024
limehee
approved these changes
Jul 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PageResponseDto의 새로운 생성자를 추가해, 대댓글 개수도 포함할 수 있도록 변경했습니다.
Tasks
PageResponseDto
생성자 추가ETC
Screenshot