Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/#103 JwtProperties 컴파일 에러 해결 #104

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

LeeHanEum
Copy link
Member

Summary

close #103

JwtProperties 컴파일 에러를 해결하였습니다.

Tasks

  • JwtProperties에 @Setter 주입

@LeeHanEum LeeHanEum added the 🐞bug Something isn't working label Nov 16, 2024
@LeeHanEum LeeHanEum requested a review from a team November 16, 2024 15:36
@LeeHanEum LeeHanEum self-assigned this Nov 16, 2024
@LeeHanEum LeeHanEum linked an issue Nov 16, 2024 that may be closed by this pull request
Copy link
Contributor

coderabbitai bot commented Nov 16, 2024

Walkthrough

이 변경 사항은 JwtProperties 클래스에 @Setter 주석을 추가하여 필드인 issuersecretKey에 대한 setter 메서드를 자동으로 생성할 수 있도록 합니다. 이 클래스는 기존의 주석인 @Getter, @Component, @NoArgsConstructor, @AllArgsConstructor, @ConfigurationProperties를 유지하며, Spring Boot 애플리케이션 내에서 JWT 속성을 구성하고 관리하는 데 사용됩니다. 전체 구조와 기능은 변경되지 않고, 주석 추가로 속성의 가변성이 향상되었습니다.

Changes

파일 경로 변경 요약
aics-common/src/main/java/kgu/developers/common/auth/jwt/JwtProperties.java @Setter 주석 추가

Assessment against linked issues

Objective Addressed Explanation
@Setter 의존성 미주입 문제 해결 (#103)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7bea2da and 545daeb.

📒 Files selected for processing (1)
  • aics-common/src/main/java/kgu/developers/common/auth/jwt/JwtProperties.java (1 hunks)
🔇 Additional comments (2)
aics-common/src/main/java/kgu/developers/common/auth/jwt/JwtProperties.java (2)

13-13: @Setter 어노테이션 추가로 컴파일 에러가 해결되었습니다.

@Setter 어노테이션 추가는 #103 이슈에서 보고된 컴파일 에러를 정확하게 해결합니다. 이는 Spring의 프로퍼티 바인딩 메커니즘이 정상적으로 작동하도록 합니다.


Line range hint 13-18: 설정 프로퍼티 바인딩 검증이 필요합니다.

application.yml 또는 application.properties에서 JWT 설정이 올바르게 바인딩되는지 확인이 필요합니다.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@LeeHanEum LeeHanEum merged commit 1d4fd47 into develop Nov 17, 2024
2 checks passed
@LeeHanEum LeeHanEum deleted the fix/#103-jwtProperties-setter-error branch November 17, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No setter found for property 버그 픽스
2 participants