Revert "fix/#111 CD 워크플로 실행 버그 픽스" #113
Conversation
This reverts commit 186f82c.
Walkthrough이 PR에서는 개발 서버에 대한 빌드 및 배포 워크플로우 구성이 변경되었습니다. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
.github/workflows/dev-build-deploy.yml:43
- The name 'docker Hub push' should be 'Docker Hub push' for consistency and correct capitalization.
- name: docker Hub push
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range and nitpick comments (1)
.github/workflows/dev-build-deploy.yml (1)
Line range hint
1-61: 워크플로우 트리거 전략 검토 필요현재 워크플로우가 수동 트리거(
workflow_dispatch)로만 설정되어 있습니다. 이는 지속적 배포(CD) 관점에서 자동화의 이점을 충분히 활용하지 못할 수 있습니다.develop브랜치에 대한 자동 배포가 필요한지 검토해 주시기 바랍니다.🧰 Tools
🪛 actionlint (1.7.4)
38-38: shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting
(shellcheck)
38-38: shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting
(shellcheck)
44-44: shellcheck reported issue in this script: SC2086:info:1:56: Double quote to prevent globbing and word splitting
(shellcheck)
🪛 yamllint (1.35.1)
[error] 61-61: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
.github/workflows/dev-build-deploy.yml(1 hunks)aics-api/src/main/resources/application.yml(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- aics-api/src/main/resources/application.yml
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/dev-build-deploy.yml
38-38: shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting
(shellcheck)
38-38: shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting
(shellcheck)
44-44: shellcheck reported issue in this script: SC2086:info:1:56: Double quote to prevent globbing and word splitting
(shellcheck)
🪛 yamllint (1.35.1)
.github/workflows/dev-build-deploy.yml
[error] 61-61: no new line character at the end of file
(new-line-at-end-of-file)
🔇 Additional comments (1)
.github/workflows/dev-build-deploy.yml (1)
52-61: 배포 구성 검증 및 파일 형식 수정 필요
- docker-compose 명령어가 단순화되었는데, 작업 디렉토리에 docker-compose.yml 파일이 있는지 확인이 필요합니다.
- 파일 끝에 개행 문자가 누락되었습니다.
다음과 같이 수정을 제안드립니다:
script: |
sudo docker-compose pull ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest
- sudo docker-compose up -d
+ sudo docker-compose up -d
+🧰 Tools
🪛 yamllint (1.35.1)
[error] 61-61: no new line character at the end of file
(new-line-at-end-of-file)
| docker push ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG | ||
| docker push ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Docker 푸시 명령어 안전성 개선 필요
변수를 포함한 Docker 푸시 명령어에도 따옴표 처리가 필요합니다.
다음과 같이 수정을 제안드립니다:
- docker push ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG
- docker push ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest
+ docker push "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG"
+ docker push "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| docker push ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG | |
| docker push ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest | |
| docker push "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG" | |
| docker push "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest" |
| env: | ||
| IMAGE_TAG: ${{ github.sha }} | ||
| run: | | ||
| docker build -t ${{ secrets.DOCKERHUB_USERNAME }}/aics-server:${{ github.sha }} . | ||
| docker tag ${{ secrets.DOCKERHUB_USERNAME }}/aics-server:${{ github.sha }} ${{ secrets.DOCKERHUB_USERNAME }}/aics-server:latest | ||
| docker build -t ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG . | ||
| docker tag ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest |
There was a problem hiding this comment.
🛠️ Refactor suggestion
쉘 스크립트 안전성 개선 및 이미지 이름 변경 확인 필요
Docker 빌드 명령어에서 변수 사용 시 따옴표 처리가 필요하며, 이미지 이름 변경이 전체 애플리케이션에서 일관되게 적용되었는지 확인이 필요합니다.
다음과 같이 수정을 제안드립니다:
- docker build -t ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG .
- docker tag ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest
+ docker build -t "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG" .
+ docker tag "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG" "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| env: | |
| IMAGE_TAG: ${{ github.sha }} | |
| run: | | |
| docker build -t ${{ secrets.DOCKERHUB_USERNAME }}/aics-server:${{ github.sha }} . | |
| docker tag ${{ secrets.DOCKERHUB_USERNAME }}/aics-server:${{ github.sha }} ${{ secrets.DOCKERHUB_USERNAME }}/aics-server:latest | |
| docker build -t ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG . | |
| docker tag ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG ${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest | |
| env: | |
| IMAGE_TAG: ${{ github.sha }} | |
| run: | | |
| docker build -t "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG" . | |
| docker tag "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:$IMAGE_TAG" "${{ secrets.DOCKERHUB_USERNAME }}/aics-api:latest" |
🧰 Tools
🪛 actionlint (1.7.4)
38-38: shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting
(shellcheck)
38-38: shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting
(shellcheck)
Reverts #112