Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/#90 pr요청 시 build CI workflow 작성 #91

Merged
merged 6 commits into from
Nov 11, 2024
Merged

chore/#90 pr요청 시 build CI workflow 작성 #91

merged 6 commits into from
Nov 11, 2024

Conversation

minjo-on
Copy link
Contributor

Summary

close #90

Tasks

  • pr요청 시 build ci workflow 작성

@minjo-on minjo-on linked an issue Nov 11, 2024 that may be closed by this pull request
Github Actions 빌드 성공 여부 CI 워크플로 작성 #90
Closed
1 task
@minjo-on minjo-on marked this pull request as ready for review November 11, 2024 10:40
@minjo-on minjo-on requested a review from a team November 11, 2024 10:40
@minjo-on minjo-on self-assigned this Nov 11, 2024
@minjo-on minjo-on added the ✨feature create new feature label Nov 11, 2024
@minjo-on minjo-on changed the title chore/#90 pr요청 시 build ci workflow 작성 chore/#90 pr요청 시 build CI workflow 작성 Nov 11, 2024
LeeHanEum
LeeHanEum reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@LeeHanEum LeeHanEum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훌륭합니다! 불필요한 주석 제거해주시고 코멘트 확인해주세요 👍

.github/workflows/ci-build.yml Outdated Show resolved Hide resolved
LeeHanEum
LeeHanEum reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@LeeHanEum LeeHanEum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이전 코멘트에 근거, ci-build.yml 이름도 수정해주세요~~

LeeHanEum
LeeHanEum approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@LeeHanEum LeeHanEum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minjo-on minjo-on merged commit 0c976cd into develop Nov 11, 2024
1 check passed
@minjo-on minjo-on deleted the feature/#90-write-build-success-workflow-with-github-actions branch November 11, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeHanEum LeeHanEum LeeHanEum approved these changes

Assignees

@minjo-on minjo-on

Labels
✨feature create new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github Actions 빌드 성공 여부 CI 워크플로 작성
2 participants
@minjo-on @LeeHanEum