New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[glyf] Respect WE_HAVE_INSTRUCTIONS on any component of a composite. #288

Closed

jfkthame wants to merge 1 commit into khaledhosny:main from jfkthame:composite-instructions

Collaborator

jfkthame commented Oct 4, 2024

Noticed in passing that the OpenTypeGLYF::ParseCompositeGlyph method doesn't quite follow the spec, which tells us that

If the flag [i.e. WE_HAVE_INSTRUCTIONS] is set on any component glyph, then a uint16 value is read immediately after the last component glyph to get the byte length for instructions.

so it's not sufficient to just check the flags that came from the last component.


          [glyf] Respect WE_HAVE_INSTRUCTIONS on any component of a composite.

7b221c5

Collaborator Author

jfkthame commented Oct 7, 2024

This is included as part of the most recent update to #289, so we can close this as a standalone PR.

jfkthame closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet