with fix in ScrollCursorToTarget, we don't need extra render steps --…

… working well in testing.
khalil-farashiani · Mar 22, 2024 · 8c776e1 · 8c776e1
1 parent 0f63905
commit 8c776e1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/texteditor/nav.go b/texteditor/nav.go
@@ -850,8 +850,6 @@ func (ed *Editor) ScrollCursorInView() bool {
 	}
 	if ed.This().(gi.Widget).IsVisible() {
 		curBBox := ed.CursorBBox(ed.CursorPos)
-		// fmt.Println("scrolling to:", curBBox, ed.CursorPos)
-		ed.SetCursorTarget(ed.CursorPos)
 		return ed.ScrollInView(curBBox)
 	}
 	return false
@@ -930,7 +928,6 @@ func (ed *Editor) ScrollCursorToTarget() {
 	ed.CursorPos = ed.CursorTarg
 	ed.ScrollCursorToVertCenter()
 	ed.SetFlag(false, EditorTargetSet)
-	ed.Scene.AddReRender(ed.This().(gi.Widget))
 }
 
 ///////////////////////////////////////////////////////////////////////////////

diff --git a/texteditor/render.go b/texteditor/render.go
@@ -34,10 +34,8 @@ func (ed *Editor) RenderLayout() {
 	chg := ed.ManageOverflow(3, true)
 	ed.LayoutAllLines()
 	ed.ConfigScrolls()
-	// _ = chg
 	if chg {
 		ed.Layout.NeedsLayout() // required to actually update scrollbar vs not
-		// 	ed.Scene.AddReRender(ed.This().(gi.Widget))
 	}
 }