-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed netcoreapp3.1, net5.0 and net6.0 + added net8.0 support #207
Removed netcoreapp3.1, net5.0 and net6.0 + added net8.0 support #207
Conversation
armanossiloko
commented
Oct 16, 2024
•
edited
Loading
edited
- Removed support for netcoreapp3.1 as it's officially out of support
- Removed support for net5.0
- Added net8.0 support
- Recreated the Middleware sample projects
@khellang Did you plan on migrating your middleware repo to net8.0 and should I go on and close the PR if you prefer to keep things as they are? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 🙏🏻 Just a few nits from me 😄
Looks like the build failed because GitHub Actions only has the |
Absolutely. I've removed it now. Let's see how it goes. |
Looks like the build is good now, but the SpaFallback tests are failing - guess changing the target framework to net8.0 was enough to break its behavior. :D When I created an MVC app on my own, it worked just fine. lol |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 81.94% 82.03% +0.09%
==========================================
Files 31 31
Lines 1102 1102
Branches 125 123 -2
==========================================
+ Hits 903 904 +1
Misses 159 159
+ Partials 40 39 -1 ☔ View full report in Codecov by Sentry. |
Thanks for your awesome contribution, @armanossiloko! 🙏🏻 |