Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed netcoreapp3.1, net5.0 and net6.0 + added net8.0 support #207

Merged
merged 10 commits into from
Oct 25, 2024

Conversation

armanossiloko
Copy link
Contributor

@armanossiloko armanossiloko commented Oct 16, 2024

  • Removed support for netcoreapp3.1 as it's officially out of support
  • Removed support for net5.0
  • Added net8.0 support
  • Recreated the Middleware sample projects

@armanossiloko
Copy link
Contributor Author

@khellang Did you plan on migrating your middleware repo to net8.0 and should I go on and close the PR if you prefer to keep things as they are?

Copy link
Owner

@khellang khellang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! 🙏🏻 Just a few nits from me 😄

src/ProblemDetails/ProblemDetails.csproj Outdated Show resolved Hide resolved
src/SpaFallback/SpaFallback.csproj Outdated Show resolved Hide resolved
test/Directory.Build.props Outdated Show resolved Hide resolved
Hellang.Middleware.sln Outdated Show resolved Hide resolved
@armanossiloko armanossiloko changed the title Removed netcoreapp3.1 and added net8.0 support Removed netcoreapp3.1, net5.0 and net6.0 + added net8.0 support Oct 25, 2024
@khellang
Copy link
Owner

Looks like the build failed because GitHub Actions only has the 8.0.402 SDK. Can we just try to remove the global.json entirely and go with the default?

@armanossiloko
Copy link
Contributor Author

Looks like the build failed because GitHub Actions only has the 8.0.402 SDK. Can we just try to remove the global.json entirely and go with the default?

Absolutely. I've removed it now. Let's see how it goes.

@armanossiloko
Copy link
Contributor Author

armanossiloko commented Oct 25, 2024

Looks like the build is good now, but the SpaFallback tests are failing - guess changing the target framework to net8.0 was enough to break its behavior. :D When I created an MVC app on my own, it worked just fine. lol

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.03%. Comparing base (86ff5dd) to head (c6e9ecb).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   81.94%   82.03%   +0.09%     
==========================================
  Files          31       31              
  Lines        1102     1102              
  Branches      125      123       -2     
==========================================
+ Hits          903      904       +1     
  Misses        159      159              
+ Partials       40       39       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khellang khellang merged commit d06f041 into khellang:master Oct 25, 2024
3 checks passed
@khellang
Copy link
Owner

Thanks for your awesome contribution, @armanossiloko! 🙏🏻

@armanossiloko armanossiloko deleted the feature/net80_migration branch October 26, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants