Merge pull request #234 from hydra/pile-improvements-2

Pile - Improve API by avoiding boolean arguments on the `show` method.

examples/pile.rs

@@ -20,7 +20,7 @@ fn main() -> cushy::Result {
                 .into_button()
                 .on_click({
                     let section = handle.clone();
-                    move |_| section.show(true)
+                    move |_| section.show_and_focus()
                 })
                 .make_widget();
             let button_id = button.id();

src/widgets/pile.rs

@@ -29,7 +29,7 @@ pub struct Pile {
 struct PileData {
     widgets: Lots<Option<WidgetInstance>>,
     visible: VecDeque<LotId>,
-    focus_visible: bool,
+    focus_on_show: bool,
 }
 
 impl PileData {
@@ -124,7 +124,7 @@ impl Widget for WidgetPile {
                 .expect("visible widget")
                 .mounted(context);
             let mut child_context = context.for_other(&visible);
-            if pile.focus_visible && self.last_visible != Some(id) {
+            if pile.focus_on_show && self.last_visible != Some(id) {
                 child_context.focus();
             }
             let size = child_context.layout(available_space);
@@ -205,20 +205,27 @@ pub struct PiledWidget(Arc<PiledWidgetData>);
 
 impl PiledWidget {
     /// Shows this widget in its pile.
-    ///
-    /// If `focus` is true, the widget will be focused when shown.
-    pub fn show(&self, focus: bool) {
+    pub fn show(&self) {
+        self.show_inner(false);
+    }
+
+    /// Shows this widget in its pile and directs keyboard focus to it.
+    pub fn show_and_focus(&self) {
+        self.show_inner(true);
+    }
+
+    fn show_inner(&self, focus: bool) {
         let mut pile = self.0.pile.data.lock();
         pile.hide_id(self.0.id);
         pile.visible.push_front(self.0.id);
-        pile.focus_visible = focus;
+        pile.focus_on_show = focus;
     }
 
     /// Removes this widget from the pile.
     pub fn remove(&self) {
         let mut pile = self.0.pile.data.lock();
         if pile.visible.front() == Some(&self.0.id) {
-            pile.focus_visible = false;
+            pile.focus_on_show = false;
         }
         pile.hide_id(self.0.id);
         pile.widgets.remove(self.0.id);