🐛 The dataservice throws 500 if gen3 does #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gen3 throws internal errors if you ask it to walk and chew gum at the same time. Then dataservice forwards the 500 status, which basically kills GF endpoint access until kids-first/kf-api-dataservice#487 gets fixed.
|
Fixes #196 |
znatty22
approved these changes
Mar 23, 2019
|
The motivation was specific, but I do think that retrying a few times on a status 500 is probably the right thing to do anyway. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gen3 throws internal errors if you ask it to walk and chew gum at the same time.
Then the dataservice forwards the 500 status, which basically kills GF endpoint access until kids-first/kf-api-dataservice#487 gets fixed.