Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛🔧 Fix/update genomic file std and target concept configuration #314

Merged
merged 5 commits into from
May 28, 2019
Merged

🐛🔧 Fix/update genomic file std and target concept configuration #314

merged 5 commits into from
May 28, 2019

Conversation

znatty22
Copy link
Member

@znatty22 znatty22 commented May 23, 2019 •
edited
Loading

No description provided.

@znatty22 znatty22 added the bug Something isn't working label May 23, 2019
@znatty22 znatty22 self-assigned this May 23, 2019
@znatty22 znatty22 requested a review from fiendish May 23, 2019 19:34
@znatty22 znatty22 changed the title 🐛🔧Fix genomic file std and target concept configuration 🐛🔧 Fix/update genomic file std and target concept configuration May 23, 2019
fiendish
fiendish suggested changes May 24, 2019
View reviewed changes
@znatty22 znatty22 force-pushed the update-fix-gf-concept-cnsts branch from 16716e5 to ed6d3b8 Compare May 24, 2019 18:54
@znatty22 znatty22 marked this pull request as ready for review May 24, 2019 18:59
@znatty22 znatty22 requested a review from a team as a code owner May 24, 2019 18:59
@znatty22 znatty22 requested a review from fiendish May 24, 2019 18:59
@znatty22 znatty22 force-pushed the update-fix-gf-concept-cnsts branch from ed6d3b8 to 71bd0db Compare May 28, 2019 14:55
fiendish
fiendish suggested changes May 28, 2019
View reviewed changes
Copy link
Contributor

@fiendish fiendish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and code that reads TSVs will need to ast.literal_eval strings that look like lists into actual lists

@znatty22 znatty22 force-pushed the update-fix-gf-concept-cnsts branch from 71bd0db to 9d7d282 Compare May 28, 2019 17:26
@znatty22 znatty22 requested a review from fiendish May 28, 2019 17:30
@znatty22 znatty22 merged commit 0dd4ce5 into master May 28, 2019
@znatty22 znatty22 deleted the update-fix-gf-concept-cnsts branch May 28, 2019 18:07
@znatty22 znatty22 mentioned this pull request Jun 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiendish fiendish fiendish approved these changes

Assignees

@znatty22 znatty22

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znatty22 @fiendish