[DROOLS-7635] ansible-rulebook : Raise an error when a condition comp… #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
force-pushed
the
DROOLS-7635-error-incompatible-type-02
branch
2 times, most recently
from
f0a727e to
f47528d
Compare
|
Added test cases:
A fix in this PR is for negation test to pass. |
…ares incompatible types - alpha index test, beta index test beta index test fix add negate test and any test
tkobayas
force-pushed
the
DROOLS-7635-error-incompatible-type-02
branch
from
f47528d to
ca9eda4
Compare
mariofusco
reviewed
Oct 10, 2024
| // if not compatible type, return false regardless of the result | ||
| // but let the operator be executed anyway so that the error message specific to the constraint is logged | ||
| boolean result = !toBeNegated.asPredicate().test(t, v); | ||
| return isCompatibleType(t, v) ? result : false; |
There was a problem hiding this comment.
Minor performance improvement: isn't necessary to compute the result if types aren't compatible.
There was a problem hiding this comment.
I wanted to let the operator log the type check error. But yes, I can refactor it to make it cleaner.
mariofusco
approved these changes
Oct 10, 2024
tkobayas
added a commit
to tkobayas/drools-ansible-rulebook-integration
that referenced
this pull request
Oct 15, 2024
kiegroup#117) * [DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types - alpha index test, beta index test beta index test fix add negate test and any test * refactor * minor comment fix
mariofusco
pushed a commit
that referenced
this pull request
Oct 18, 2024
…on compares incompatible types (#120) * Merge pull request #114 from tkobayas/DROOLS-7635-error-incompatible-type-02 [DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types * [DROOLS-7635] ansible-rulebook : Raise an error when a condition comp… (#117) * [DROOLS-7635] ansible-rulebook : Raise an error when a condition compares incompatible types - alpha index test, beta index test beta index test fix add negate test and any test * refactor * minor comment fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ares incompatible types