Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO-NOT-MERGE] [DROOLS-7554] Retain partial match for peer tuples #82

Closed
wants to merge 1 commit into from
Closed

[DO-NOT-MERGE] [DROOLS-7554] Retain partial match for peer tuples #82

wants to merge 1 commit into from

Conversation

tkobayas
Copy link
Collaborator

  • WIP

tkobayas
tkobayas commented Sep 19, 2023
View reviewed changes
...ion-api/src/test/java/org/drools/ansible/rulebook/integration/api/MultipleRuleMatchTest.java
// when multiple match is allowed i=0 and j=0 should be retained and now used to also fire R4
assertThat(matchedRules.stream().map(m -> m.getRule().getName())).contains("R4");
// if all rules fired now the working memory should be empty
assertThat(rulesExecutor.getAllFacts()).isEmpty();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails here, because i=0 and j=0 are still in working memory.

With a Debugger, I see that the first peer (= JoinNodeLT[12]) didn't have a child (It should be RTNLT of R3) when checking the partial match for R4 firing.

@tkobayas tkobayas closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tkobayas