[DROOLS-7589] ansible-rulebook : Throw Exception when heap reaches to… #90
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| package org.drools.ansible.rulebook.integration.api.rulesengine; | ||
|
|
||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class MemoryMonitorUtil { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(MemoryMonitorUtil.class.getName()); | ||
|
|
||
| public static final String MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD_PROPERTY = "drools.memory.occupation.percentage.threshold"; | ||
| private static final int DEFAULT_MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD = 90; | ||
| private static final int MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD; | ||
|
|
||
| // check memory per configured number of events are consumed | ||
| public static final String MEMORY_CHECK_EVENT_COUNT_THRESHOLD_PROPERTY = "drools.memory.check.event.count.threshold"; | ||
| private static final int DEFAULT_MEMORY_CHECK_EVENT_COUNT_THRESHOLD = 64; | ||
| private static final int MEMORY_CHECK_EVENT_COUNT_MASK; | ||
| private static int COUNTER = 0; | ||
|
|
||
| static { | ||
| String memoryThresholdEnvValue = System.getenv("DROOLS_MEMORY_THRESHOLD"); | ||
| if (memoryThresholdEnvValue != null && !memoryThresholdEnvValue.isEmpty()) { | ||
| // Environment variable takes precedence over system property | ||
| System.setProperty(MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD_PROPERTY, memoryThresholdEnvValue); | ||
| } | ||
| MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD = Integer.getInteger(MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD_PROPERTY, DEFAULT_MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD); // percentage | ||
| LOG.info("Memory occupation threshold set to {}%", MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD); | ||
|
|
||
| String eventCountThresholdEnvValue = System.getenv("DROOLS_MEMORY_CHECK_EVENT_COUNT_THRESHOLD"); | ||
| if (eventCountThresholdEnvValue != null && !eventCountThresholdEnvValue.isEmpty()) { | ||
| // Environment variable takes precedence over system property | ||
| System.setProperty(MEMORY_CHECK_EVENT_COUNT_THRESHOLD_PROPERTY, eventCountThresholdEnvValue); | ||
| } | ||
|
|
||
| int eventCountThreshold = Integer.getInteger(MEMORY_CHECK_EVENT_COUNT_THRESHOLD_PROPERTY, DEFAULT_MEMORY_CHECK_EVENT_COUNT_THRESHOLD); // number of events | ||
| MEMORY_CHECK_EVENT_COUNT_MASK = roundToPowerOfTwo(eventCountThreshold) - 1; | ||
| LOG.info("Memory check event count threshold set to {}", MEMORY_CHECK_EVENT_COUNT_MASK); | ||
| } | ||
|
|
||
| private MemoryMonitorUtil() { | ||
| // do not instantiate | ||
| } | ||
|
|
||
| public static void checkMemoryOccupation() { | ||
| if ((COUNTER++ & MEMORY_CHECK_EVENT_COUNT_MASK) == 0) { | ||
| // check memory occupation only once in 64 calls | ||
| return; | ||
| } | ||
| int memoryOccupationPercentage = getMemoryOccupationPercentage(); | ||
| if (memoryOccupationPercentage > MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD) { | ||
| // give GC a chance to free some memory | ||
| System.gc(); // NOSONAR | ||
| memoryOccupationPercentage = getMemoryOccupationPercentage(); | ||
| if (memoryOccupationPercentage > MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD) { | ||
| LOG.error("Memory occupation is above the threshold: {}% > {}%. MaxMemory = {}, UsedMemory = {}", | ||
| memoryOccupationPercentage, MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD, Runtime.getRuntime().maxMemory(), Runtime.getRuntime().totalMemory() - Runtime.getRuntime().freeMemory()); | ||
| throw new MemoryThresholdReachedException(MEMORY_OCCUPATION_PERCENTAGE_THRESHOLD, memoryOccupationPercentage); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private static int getMemoryOccupationPercentage() { | ||
| return (int) ((100 * (Runtime.getRuntime().totalMemory() - Runtime.getRuntime().freeMemory())) / Runtime.getRuntime().maxMemory()); | ||
| } | ||
|
|
||
| private static int roundToPowerOfTwo(final int value) { | ||
| if (value > Integer.MAX_VALUE) { | ||
| throw new IllegalArgumentException("There is no larger power of 2 int for value:" + value + " since it exceeds 2^31."); | ||
| } | ||
| if (value < 0) { | ||
| throw new IllegalArgumentException("Given value:" + value + ". Expecting value >= 0."); | ||
| } | ||
| return 1 << (32 - Integer.numberOfLeadingZeros(value - 1)); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package org.drools.ansible.rulebook.integration.api.rulesengine; | ||
|
|
||
| public class MemoryThresholdReachedException extends RuntimeException { | ||
|
|
||
| private final int threshold; | ||
| private final int actual; | ||
|
|
||
| public MemoryThresholdReachedException(int threshold, int actual) { | ||
| this.threshold = threshold; | ||
| this.actual = actual; | ||
| } | ||
|
|
||
| @Override | ||
| public String getMessage() { | ||
| return "Memory threshold reached: " + actual + "% > " + threshold + "%"; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the place where we can check the memory before sync/async execution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that checking this synchronously and at each and every rule evaluation is a good idea. I'm afraid the overhead could be relevant and not totally justified. One possibility is to run this asynchronously as a timed task. Another alternative is doing it here and synchronously but actually doing the check (and running the gc) only once in fixed number (100?) of evaluations. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I agree that we want to minimize the overhead. Probably the former (time-based check) may miss "quickly incoming many events" scenario. So I guess the latter (number-based check) is better?