-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-10176] Detect creation of timers for notifications #2283
Conversation
jenkins retest this |
...-human-task-core/src/main/java/org/jbpm/services/task/impl/util/DeadlineSchedulerHelper.java
Outdated
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/instance/timer/TimerJobContext.java
Outdated
Show resolved
Hide resolved
...b/jbpm-services-ejb-timer/src/main/java/org/jbpm/services/ejb/timer/EjbSchedulerService.java
Outdated
Show resolved
Hide resolved
a439f93
to
eec2f62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @albfan
jenkins retest this |
1 similar comment
jenkins retest this |
@gmunozfe Seems that this CI is not taken the Drools PR and hence compilation is failing, any clue why this might happen. The branches seems to have the same name. |
@fjtirado Cannot create a JBPM issue. associated PR are rebased to 7.x branch |
Kudos, SonarCloud Quality Gate passed! |
Co-authored-by: Alberto Fanjul <[email protected]>
Co-authored-by: Alberto Fanjul <[email protected]>
Co-authored-by: Alberto Fanjul <[email protected]>
Co-authored-by: Alberto Fanjul <[email protected]>
Co-authored-by: Alberto Fanjul <[email protected]>
Co-authored-by: Alberto Fanjul <[email protected]>
Co-authored-by: Alberto Fanjul <[email protected]>
Co-authored-by: Alberto Fanjul <[email protected]>
Co-authored-by: Alberto Fanjul <[email protected]> Co-authored-by: Alberto Fanjul <[email protected]>
Co-authored-by: Alberto Fanjul <[email protected]> Co-authored-by: Alberto Fanjul <[email protected]>
JBPM-10176
needs:
Add a TimerJobContext to detect if a job is just created to not look for it in existing timers
The problem is only noticeable if you have lot of timers and creates a new notifications.
The interface allow any other job creating timers to control this behaviour.