Fixed deadlock during destruction #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally your fix seems sensible, if I saw that correctly it's basically the patch suggested in one of the ros issues? Do we build the geometry already ourselves or is this our first adaptation? In any case, we should also try to get this fix upstream. As the patch is already posted to the original ros issue we could e.g. open a MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destructor in tf2_ros::TransformListener causes a deadlock in rare cases, which results that the spin thread never terminates. This causes flaky unit tests.
Relevant issues:
ros2#517
ros2#518