Responsive improvement and fix header cells width #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally when the window size changes StickyHeader will keep using old values.
With the addition of jQuery(window).on('resize', reInitStickyHeaders); the init function will run again on resizing of the window.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsive
I moved the anonymous function to a named function.
I added a window resize handler that will call
InitStickyHeaderseInit().This function removes the old sticky header and handlers. Finally it will call
initStickyHeaders()again.Cell width
To fix the header cell width I changed line 30 to use the
outerWidth()property instead ofwidth(). This will take the full width of header cells.