Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types #158

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Fix types #158

merged 2 commits into from
Jan 21, 2025

Conversation

robertherber
Copy link
Member

@robertherber robertherber commented Jan 21, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Improved type safety for environment variable parsing in the @zemble/utils package.
  • Chores

    • Added a changeset for tracking package updates.

Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 559fd5a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@zemble/utils Patch
@zemble/auth-anonymous Patch
@zemble/auth-otp Patch
@zemble/bull Patch
@zemble/cms-users Patch
@zemble/cms Patch
@zemble/core Patch
@zemble/firebase-auth Patch
@zemble/push-expo Patch
supplement-stack Patch
@zemble/todo Patch
todo-app-with-auth-backend Patch
minimal Patch
@zemble/ignite Patch
@zemble/apple-app-site-association Patch
@zemble/auth-api-token Patch
@zemble/auth-apple Patch
@zemble/auth Patch
@zemble/bun Patch
@zemble/debug Patch
@zemble/email-resend Patch
@zemble/email-sendgrid Patch
@zemble/graphql Patch
@zemble/kv Patch
@zemble/logger-graphql Patch
@zemble/migrations Patch
@zemble/mongodb Patch
@zemble/node Patch
@zemble/pino Patch
@zemble/push-apple Patch
@zemble/routes Patch
@zemble/sms-46elks Patch
@zemble/sms-twilio Patch
@zemble/supabase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

coderabbitai bot commented Jan 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A patch has been introduced for the @zemble/utils package, focusing on type improvements in the parseEnvEnum function within the parseEnv.ts file. The changes involve type assertions to enhance type safety, specifically modifying how array values are handled and type-checked. These modifications aim to provide more robust type handling without altering the core functionality of the environment variable parsing mechanism.

Changes

File Change Summary
packages/utils/node/parseEnv.ts Updated type assertions in parseEnvEnum function:
- Explicitly asserted enumOrArray as readonly T[]
- Modified type casting for rawValue when checking enum inclusion

Poem

🐰 Typeful Rabbit's Type-Safe Delight

In utils, where types take flight,
Assertions dance with rabbit might,
Enum parsing, now crystal clear,
No more type worries, have no fear!

Hop hop, type safe! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ac2103 and 559fd5a.

📒 Files selected for processing (2)
  • .changeset/giant-snails-sort.md (1 hunks)
  • packages/utils/node/parseEnv.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@robertherber robertherber merged commit 03712a2 into main Jan 21, 2025
6 of 8 checks passed
@robertherber robertherber deleted the fix-types branch January 21, 2025 23:51
Copy link

pkg-pr-new bot commented Jan 21, 2025

Open in Stackblitz

@zemble/auth

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth@158

@zemble/auth-anonymous

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth-anonymous@158

@zemble/auth-apple

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth-apple@158

@zemble/auth-api-token

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth-api-token@158

@zemble/auth-otp

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/auth-otp@158

@zemble/bull

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/bull@158

@zemble/bun

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/bun@158

@zemble/core

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/core@158

create-zemble-app

npm i https://pkg.pr.new/kingstinct/zemble/create-zemble-app@158

create-zemble-plugin

npm i https://pkg.pr.new/kingstinct/zemble/create-zemble-plugin@158

@zemble/debug

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/debug@158

@zemble/email-resend

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/email-resend@158

eslint-config-kingstinct

npm i https://pkg.pr.new/kingstinct/zemble/eslint-config-kingstinct@158

@zemble/firebase-auth

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/firebase-auth@158

@zemble/email-sendgrid

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/email-sendgrid@158

@zemble/graphql

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/graphql@158

@zemble/kv

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/kv@158

@zemble/migrations

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/migrations@158

@zemble/mongodb

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/mongodb@158

@zemble/node

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/node@158

@zemble/pino

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/pino@158

@zemble/push-apple

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/push-apple@158

@zemble/push-expo

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/push-expo@158

@zemble/react

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/react@158

@zemble/routes

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/routes@158

@zemble/sms-46elks

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/sms-46elks@158

@zemble/sms-twilio

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/sms-twilio@158

@zemble/supabase

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/supabase@158

@zemble/utils

npm i https://pkg.pr.new/kingstinct/zemble/@zemble/utils@158

commit: 559fd5a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant