Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Enhance User Feedback for Web Access Type Favorites #20

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Feature: Enhance User Feedback for Web Access Type Favorites #20

merged 1 commit into from
Feb 29, 2024

Conversation

bshutterkion
Copy link
Collaborator

Overview

This PR introduces a user-friendly message that enhances the feedback provided when selecting a favorite with access_type set to web. This message informs the user about the account name, account number, and the AWS IAM role name being accessed, providing a clearer understanding of the federating process.

Changes

  • Added a fmt.Printf statement to display the federating account's name, account number, and AWS IAM role name before opening the browser for web access type favorites.

Testing

  • Manual tests were conducted to ensure the message correctly displays the intended information.
  • Verified that the browser opens as expected and the federating process proceeds without any issues.

@bshutterkion
Copy link
Collaborator Author

This looks like:

Choose a Favorite: bshutter-sandbox
Federating into bshutter-sandbox (525978902008) via ctcorp-delivery

@codybuell codybuell self-requested a review February 29, 2024 20:35
@codybuell codybuell self-assigned this Feb 29, 2024
@codybuell codybuell merged commit 6f93afe into kionsoftware:main Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants