Add support for account alias and account id in console federation #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l commands - Modified the `GetFederationURL` function to accept an `accountAlias` parameter. - Enhanced the `fedConsole` function to allow fetching CAR details using both `accountAlias` and `carName` directly. - Added new CLI flags (`alias`, `car`) to the federation console command for improved usability.
…ole commands - Enhanced the `GetFederationURL` function in `console.go` to accept an `accountAlias` parameter. - Updated the README.md to include instructions and notes regarding account alias support for Kion versions 3.9.9, 3.10.2, and above. - Clarified alias usage in the console commands, including both sub-shell and federation options. - Modified CLI flag descriptions in `main.go` to specify that `alias` must be used in conjunction with `car`.
- Updated README.md with consistent usage of "NOTE" format for clarity - Added missing documentation for the console command options - Removed `AccountAlias` field from `URLRequest` struct in console.go - Refactored `GetFederationURL` function to remove unused `accountAlias` parameter - Fixed inconsistent capitalization of "Kion" and "CSP" across codebase - Minor improvements to comment formatting and corrected usage descriptions in main.go
- Added `validateCmdConsole` function to ensure proper flag combinations for the console command. - Enforces that the `--car` flag must be passed with either `--account` or `--alias`. - Throws an error if `--account` or `--alias` is used without `--car`. - Modified `fedConsole` to handle cases where either `--account` or `--alias` can be used with `--car`. - Added logic to fetch CAR by account number or alias. - Introduced `--account` flag alongside `--car` and `--alias` in the console command.
…account number - Added documentation for the `--account` option in the `kion console` command to allow federating into a web console using an account number. - Updated the OPTIONS section to include details for the `--account` flag, which bypasses prompts when used with `--car`.
bshutterkion
changed the title
- Updated the README.md to fix a note formatting regarding Firefox pop-up approval.
- Removed unnecessary file-level comments from main.go to improve code clarity.
…nt number - Introduced `Alias` field to `kion.Account` and `kion.CAR` structs. - Updated tests to reflect the new `Alias` field in account and CAR mappings. - Added `FindCARByNameAndAccountNumber` and `FindCARByNameAndAlias` helper functions to search CARs using account number and alias respectively. - Enhanced test coverage for the new helper functions with various edge cases (finding CARs by account number and alias).
…est.go The border of the comment block in `helper_test.go` was adjusted to remove extra characters for consistency and formatting purposes.
…ccount ID Removed unneeded comments in transform_test.go
…d helper functions - Updated README to clarify that account alias is only supported in Kion versions 3.9.9, 3.10.2, and later. - Removed unneeded helper functions `FindCARByNameAndAccountNumber` and `FindCARByNameAndAlias` from `helper_test.go` and `transform_test.go`, along with their corresponding test cases.
codybuell
approved these changes
Sep 17, 2024
bdljohnson
approved these changes
Sep 17, 2024
bshutterkion
deleted the
feat(console)-add-account-alias-support-to-console-commands
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
aliassupport for account selection in thekion consolecommand, allowing users to specify an account alias.accountsupport for account selection in thekion consolecommand, allowing users to specify an account number.kion consoleto ensure correct flag combinations are passed (--accountor--aliasmust be used with--car).Changed
fedConsoleand related helper functions.kion stakandkion console.kion console.aliasfunctionality requiring Kion versions 3.9.9 and 3.10.2 and up.Fixed