Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Remove old code relict which creates wrong log entries #1452

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

stweil
Copy link
Member

@stweil stweil commented Feb 1, 2025

The conditional statement is always true which does not make sense and which can result in a log message "Incomplete plugin configuration".

The conditional statement is always true which does not make sense and
which can result in a log message "Incomplete plugin configuration".

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Member Author

stweil commented Feb 1, 2025

See related discussion.

@sebastian-meyer sebastian-meyer self-requested a review February 1, 2025 14:53
@sebastian-meyer sebastian-meyer added the 🐛 bug A non-security related bug. label Feb 1, 2025
@sebastian-meyer sebastian-meyer changed the title Remove old code relict which creates wrong log entries [BUGFIX] Remove old code relict which creates wrong log entries Feb 1, 2025
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (b227afc) to head (cff6362).
Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #1452   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastian-meyer sebastian-meyer merged commit addd63e into kitodo:main Feb 1, 2025
10 checks passed
@stweil stweil deleted the remove_old_code branch February 1, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug A non-security related bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants