[CONFIGURATION] Do not run the GitHub action deploy job in forks #1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forks cannot deploy the documentation, so this action always failed for the main branch of forks. Signed-off-by: Stefan Weil <[email protected]>
|
Maybe forks should not run the "documentation" action at all. Should I modify the PR to restrict the whole workflow to the kitodo owner? |
sebastian-meyer
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1456 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. |
sebastian-meyer
approved these changes
Feb 1, 2025
|
I think your changes are fine. The workflow should be available on forks in order to at least be able to build documentation - even if deployment fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forks cannot deploy the documentation, so this action always failed for the main branch of forks.