This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Fixes #71 #72
Merged
Fixes #71 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Without tests I can not reproduce it before or after applying your patch as we did not use this feature and I have no process with this kind of meta data. |
henning-gerhardt
approved these changes
Jan 11, 2018
|
See also https://github.com/intranda/ugh/blob/master/ugh/src/ugh/dl/DocStruct.java#L565 which looks like the fixed code. Commit intranda/ugh@7f699d4 fixed the problem and is identical to the current pull request. Are there more old fixes in the Intranda fork which we should backport? |
stweil
approved these changes
Jan 11, 2018
|
@stweil: Do not ask me as I did not know this if there are more bugs and / or bug fixes in other forks of this library. If some body did some fixing and did not offer this as a pull request against this repo then I did not know about this bug fixing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #71