This repository has been archived by the owner on Jan 8, 2025. It is now read-only.
Feat/clean dependencies #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eikix
force-pushed
the
feat/clean_dependencies
branch
from
570491c to
28636f6
Compare
Eikix
force-pushed
the
feat/clean_dependencies
branch
from
28636f6 to
2905ab5
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
===========================================
+ Coverage 23.17% 72.87% +49.69%
===========================================
Files 9 45 +36
Lines 1247 4140 +2893
===========================================
+ Hits 289 3017 +2728
- Misses 958 1123 +165
☔ View full report in Codecov by Sentry. |
anukkrit149
pushed a commit
to karnotxyz/kakarot-rpc
that referenced
this pull request
Aug 9, 2024
Time spent on this PR: 0.2 ## Pull request type Please check the type of change your PR introduces: - [ ] Bugfix - [ ] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [x] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ## What is the current behavior? No Docker image for just deploying the kakarot contracts to a given network. ## What is the new behavior? Added a deployer image such that ```bash docker run -e SHARINGAN_ACCOUNT_ADDRESS= -e SHARINGAN_PRIVATE_KEY= -e SHARINGAN_RPC_URL= deployer ``` will deploy Kakarot to the given `SHARINGAN_RPC_URL` network, using as deployer `SHARINGAN_ACCOUNT_ADDRESS` with private key `SHARINGAN_PRIVATE_KEY`. ## Other information
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time spent on this PR:
Resolves: #637
Pull Request type
Please check the type of change your PR introduces:
What is the new behavior?
Does this introduce a breaking change?