Skip to content
This repository has been archived by the owner on Jan 8, 2025. It is now read-only.

fix: build of artifacts #686

Closed
wants to merge 7 commits into from
Closed

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Jan 4, 2024

Time spent on this PR: 0.2 day

Resolves: #NA

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing

What is the new behavior?

Container should build correctly.

Does this introduce a breaking change?

  • Yes
  • No

This change is Reviewable

@greged93 greged93 changed the title fix: add build of artifacts fix: build of artifacts Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 732 lines in your changes are missing coverage. Please review.

Comparison is base (71506a8) 23.17% compared to head (b92c3b0) 69.03%.
Report is 257 commits behind head on main.

Files Patch % Lines
src/starknet_client/mod.rs 51.81% 212 Missing ⚠️
src/eth_rpc/servers/eth_rpc.rs 27.01% 208 Missing ⚠️
src/starknet_client/config.rs 17.24% 72 Missing ⚠️
src/starknet_client/errors.rs 10.00% 36 Missing ⚠️
src/main.rs 0.00% 30 Missing ⚠️
src/starknet_client/helpers.rs 47.27% 29 Missing ⚠️
src/models/call.rs 90.34% 17 Missing ⚠️
src/models/transaction/transaction.rs 83.33% 17 Missing ⚠️
src/bin/dump-genesis.rs 0.00% 16 Missing ⚠️
src/eth_rpc/servers/net_rpc.rs 16.66% 15 Missing ⚠️
... and 17 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #686       +/-   ##
===========================================
+ Coverage   23.17%   69.03%   +45.85%     
===========================================
  Files           9       34       +25     
  Lines        1247     2364     +1117     
===========================================
+ Hits          289     1632     +1343     
+ Misses        958      732      -226     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Eikix
Eikix previously approved these changes Jan 4, 2024
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@greged93
Copy link
Contributor Author

greged93 commented Jan 5, 2024

closed in favour of #689

@greged93 greged93 closed this Jan 5, 2024
anukkrit149 pushed a commit to karnotxyz/kakarot-rpc that referenced this pull request Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants