feat: incorporate child #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eikix
reviewed
Jan 24, 2025
Eikix
reviewed
Jan 24, 2025
Eikix
reviewed
Jan 24, 2025
Eikix
reviewed
Jan 24, 2025
obatirou
reviewed
Jan 24, 2025
enitrat
force-pushed
the
feat/incorporate-child
branch
3 times, most recently
from
637ba30 to
5db356d
Compare
enitrat
force-pushed
the
feat/incorporate-child
branch
from
5db356d to
6b29052
Compare
|
@Eikix ready khap |
obatirou
reviewed
Jan 26, 2025
| new TupleLogStruct(data=evm.value.logs.value.data, len=evm.value.logs.value.len + len) | ||
| ); | ||
|
|
||
| let new_refund_counter = evm.value.refund_counter + child_evm.value.refund_counter; |
There was a problem hiding this comment.
This could overflow. Add a comment why this cannot or add a check to ensure it does not.
Same for gas left.
obatirou
reviewed
Jan 26, 2025
| // they were moved into the Evm, which we just squashed. | ||
|
|
||
| // No need to squash the env's `state` and `transient_storage` because it was handled in `rollback_transaction`, | ||
| // when we squashed and appended the prev keys to the parent's state and transient storage segments. |
There was a problem hiding this comment.
why rollback_transaction is mentioned even though it is the success case? Shouldn't this be commit_transaction?
obatirou
reviewed
Jan 26, 2025
Comment on lines
+336
to
+337
| // No need to squash the message's `accessed_addresses` and `accessed_storage_keys` because | ||
| // they were moved into the Evm, which we just squashed. |
There was a problem hiding this comment.
I am not sure about this formulation. It should explicitly say that the those dict are shared between the message and the Evm for more context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #531