Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Testing cla #25

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Testing cla #25

merged 2 commits into from
Feb 10, 2023

Conversation

Sotatek-TinnNguyen
Copy link
Contributor

Proposed changes

  • Describe your changes to communicate to the maintainers why we should accept this pull request.
  • If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or Enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have signed the CLA by posting "I have read the CLA Document and I hereby sign the CLA" in the comment
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you proposed and what alternatives you have considered, etc.

@markyim-kaia
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

@markyim-kaia markyim-kaia merged commit 1bc5639 into main Feb 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
@0xxlegolas 0xxlegolas deleted the testing_cla branch February 13, 2023 03:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants