Don't treat Nav Key to move as an error #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing the navigation key to move was fixed earlier, but it never actually worked in practice. The change of path was still treated as an error condition.
|
bump? |
|
bump |
|
bump? |
|
bump? :..( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About a year ago an issue was fixed where moving the Navigation Key in the application Model would make Hot Reloading fail. While the logic to detect the new location of the key was implemented, the code still seems to treat the move as an error condition.
The fix was in
1.1.4:It seems that the check for what was previously considered an error is still in place. This PR will remove that check and just update the key.