fix(ui): added card's state not being updated

kleinfreund · Dec 9, 2024 · c29e1ac · c29e1ac
1 parent 38dcf99
commit c29e1ac
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/src/ui/UiState.ts b/src/ui/UiState.ts
@@ -215,16 +215,24 @@ export class UiState {
 	addJoker (joker?: Joker) {
 		this.jokerContainer.insertAdjacentHTML('beforeend', '<joker-card></joker-card>')
 		const jokerEl = this.jokerContainer.lastElementChild
-		if (joker && jokerEl instanceof JokerCard) {
-			jokerEl.setJoker(joker)
+		if (jokerEl instanceof JokerCard) {
+			if (joker) {
+				jokerEl.setJoker(joker)
+			}
+
+			jokerEl.updateState()
 		}
 	}
 
 	addCard (card?: Card, isPlayed?: boolean) {
 		this.playingCardContainer.insertAdjacentHTML('beforeend', '<playing-card></playing-card>')
 		const el = this.playingCardContainer.lastElementChild
-		if (card && el instanceof PlayingCard) {
-			el.setCard(card, isPlayed)
+		if (el instanceof PlayingCard) {
+			if (card) {
+				el.setCard(card, isPlayed)
+			}
+
+			el.updateState()
 		}
 	}
 

diff --git a/src/ui/components/JokerCard.ts b/src/ui/components/JokerCard.ts
@@ -138,8 +138,6 @@ export class JokerCard extends DraggableCard {
 		if (this.#definition.hasIsActiveInput) this.isActiveCheckbox.checked = Boolean(isActive)
 		if (this.#definition.hasRankInput && rank) this.rankSelect.value = String(rank)
 		if (this.#definition.hasSuitInput && suit) this.suitSelect.value = String(suit)
-
-		this.updateState()
 	}
 
 	updateState () {

diff --git a/src/ui/components/PlayingCard.ts b/src/ui/components/PlayingCard.ts
@@ -128,8 +128,6 @@ export class PlayingCard extends DraggableCard {
 		this.editionSelect.value = edition
 		this.enhancementSelect.value = enhancement
 		this.sealSelect.value = seal
-
-		this.updateState()
 	}
 
 	updateState () {