Specify utf-8 encoding when writing a file in router.py #231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without specifying "utf-8" encoding when writing a file the script fails to write text to a file in many cases.
I can't say if it's specific to OS region\language or contents of the file, but this simple change fixes any such issues, tested locally.
Changes in this PR
Add
encoding="utf-8"
to the file open on write.cc/ @klen