Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Kind and k8s version #790

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Dec 20, 2024

Changes

  • As per title.

Copy link

knative-prow bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dprotaso and upodroid December 20, 2024 15:16
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 20, 2024
@skonto
Copy link
Contributor Author

skonto commented Dec 20, 2024

We need to fix envoygateway installation:

customresourcedefinition.apiextensions.k8s.io/udproutes.gateway.networking.k8s.io created
error: unable to read URL "https://github.com/envoyproxy/gateway/releases/download/latest/install.yaml", server reported 404 Not Found, status code=404
configmap/config-gateway configured

Either we pin or install differently.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2024
@dprotaso
Copy link
Contributor

Pinned the envoy gateway version

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.89%. Comparing base (8c9f69b) to head (71dcfd9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage   79.89%   79.89%           
=======================================
  Files          17       17           
  Lines        1597     1597           
=======================================
  Hits         1276     1276           
  Misses        285      285           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Contributor

/test integration-tests-envoy-gateway_net-gateway-api_main

@dprotaso
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2024
@knative-prow knative-prow bot merged commit 9734fb9 into knative-extensions:main Dec 21, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants