Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RequestReply: Added feature flag for default timeout #8361

Merged
merged 2 commits into from
Dec 5, 2024
Merged

RequestReply: Added feature flag for default timeout #8361

merged 2 commits into from
Dec 5, 2024

Conversation

AlexMamoukarys
Copy link
Contributor

@AlexMamoukarys AlexMamoukarys commented Dec 1, 2024 •
edited
Loading

_

Fixes #8338

Proposed Changes

  • Add feature flag for default timeout on RequestReply resources
  • Use feature flag in webhook

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Made request reply timeout configurable through config-features

Docs

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 1, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from creydr and pierDipi December 1, 2024 20:46
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 1, 2024

Welcome @AlexMamoukarys! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 1, 2024

Hi @AlexMamoukarys. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Cali0707
Copy link
Member

Cali0707 commented Dec 1, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 1, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 64.14%. Comparing base (7176ce6) to head (093eb19).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
pkg/apis/feature/features.go 55.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8361      +/-   ##
==========================================
- Coverage   64.23%   64.14%   -0.09%     
==========================================
  Files         390      389       -1     
  Lines       23248    23335      +87     
==========================================
+ Hits        14934    14969      +35     
- Misses       7520     7571      +51     
- Partials      794      795       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member

Cali0707 commented Dec 2, 2024

/cc @pierDipi @creydr @matzew
Could one of you review this? I worked on this PR with @AlexMamoukarys , so I probably shouldn't review it

@knative-prow knative-prow bot requested a review from matzew December 2, 2024 14:45
pierDipi
pierDipi approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexMamoukarys

Left a few comments

pkg/apis/feature/features.go Outdated
return string(DefaultRequestReplyTimeout)
}

return string(timeout) // TODO, check this, check this whole function really
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of leaving a TODO here, can you track this in an issue?

Copy link
Contributor Author

@AlexMamoukarys AlexMamoukarys Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to remove these TODOs when I committed, sorry - I made a new commit to fix this

pkg/apis/feature/flag_names.go Outdated
NewAPIServerFilters = "new-apiserversource-filters"
AuthorizationDefaultMode = "default-authorization-mode"
OIDCDiscoveryBaseURL = "oidc-discovery-base-url"
RequestReplyDefaultTimeout = "requestreply-default-timeout" // TODO check this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of leaving a TODO here, can you track this in an issue?

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 4, 2024
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
Cali0707
Cali0707 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nice work @AlexMamoukarys, thanks for the PR!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexMamoukarys, Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 8d8b6c9 into knative:main Dec 5, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@pierDipi pierDipi pierDipi approved these changes

@creydr creydr Awaiting requested review from creydr

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RequestReply: Configure Timeout Default in Feature Configmap
3 participants
@AlexMamoukarys @Cali0707 @pierDipi