Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] Make adapter pkg independent from brokerfilter package #8373

Conversation

creydr
Copy link
Member

@creydr creydr commented Dec 4, 2024

In the apiserversource receive adapter for 1.15 (not on main), we see the following errors

W1204 13:41:06.207735       1 reflector.go:539] k8s.io/[email protected]/tools/cache/reflector.go:229: failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:default:api-src-user" cannot list resource "secrets" in API group "" in the namespace "knative-eventing"
E1204 13:41:06.207756       1 reflector.go:147] k8s.io/[email protected]/tools/cache/reflector.go:229: Failed to watch *v1.Secret: failed to list *v1.Secret: secrets is forbidden: User "system:serviceaccount:default:api-src-user" cannot list resource "secrets" in API group "" in the namespace "knative-eventing"

This is because of the dependency of the adapter package to brokerfilters which use the secret informers

"knative.dev/eventing/pkg/adapter/apiserver"

->
brokerfilter "knative.dev/eventing/pkg/broker/filter"

->
secretinformer "knative.dev/pkg/injection/clients/namespacedkube/informers/core/v1/secret"

This PR addresses it and uses the subscriptionapi refactoring from #8122 to remove this dependency

@creydr creydr requested review from maschmid and pierDipi December 4, 2024 14:33
@knative-prow knative-prow bot requested a review from Cali0707 December 4, 2024 14:33
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2024
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2024
Copy link

knative-prow bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 20e5495 into knative:release-1.15 Dec 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants