Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(STONEINTG-1072): removing sidecard and implement it by Clamav DB #1645

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

kasemAlem
Copy link
Contributor

Before you complete this pull request ...

Look for any open pull requests in the repository with the title "e2e-tests update" and
see if there are recent e2e-tests updates that will be applicable to your change.

@kasemAlem kasemAlem force-pushed the STONEINTG-1072-clamav-scan branch 2 times, most recently from 26c970a to f47fe4c Compare November 25, 2024 11:15
@kasemAlem kasemAlem marked this pull request as ready for review November 25, 2024 11:43
@kasemAlem kasemAlem force-pushed the STONEINTG-1072-clamav-scan branch 5 times, most recently from cb3f590 to ba847f0 Compare November 26, 2024 15:27
@kasemAlem kasemAlem force-pushed the STONEINTG-1072-clamav-scan branch 3 times, most recently from f3a57e4 to 54a99f8 Compare November 28, 2024 10:24
@kasemAlem kasemAlem requested a review from jsztuka November 28, 2024 11:57
@kasemAlem
Copy link
Contributor Author

/retest

@kasemAlem kasemAlem force-pushed the STONEINTG-1072-clamav-scan branch 4 times, most recently from 4e69e1b to 2bef15d Compare December 2, 2024 18:15
@kasemAlem
Copy link
Contributor Author

check this newer run log, duration took 4 minutes

step-extract-and-scan-image

Extracting image(s).
Running "oc image extract" on image of arch amd64
Scanning image for arch amd64. This operation may take a while.
LibClamAV Warning: Max file-size was set to 4293918720 bytes. Unfortunately, scanning files greater than 2147483647 bytes (2 GiB - 1) is not supported.

----------- SCAN SUMMARY -----------
Known viruses: 8700659
Engine version: 1.0.7
Scanned directories: 2933
Scanned files: 24155
Infected files: 0
Data scanned: 1051.98 MB
Data read: 880.60 MB (ratio 1.19:1)
Time: 188.728 sec (3 m 8 s)
Start Date: 2024:12:02 18:25:08
End Date:   2024:12:02 18:28:17
Executed-on: Scan was executed on clamscan version - ClamAV 1.0.7/27474/Sun Dec  1 09:42:26 2024 Database version: 27474
[
	{
		"filename": "/work/logs/clamscan-result-log-amd64.json",
		"namespace": "required_checks",
		"successes": 2
	}
]
{"timestamp":"1733164097","namespace":"required_checks","successes":2,"failures":0,"warnings":0,"result":"SUCCESS","note":"All checks passed successfully"}
{"timestamp":"1733164097","namespace":"required_checks","successes":2,"failures":0,"warnings":0,"result":"SUCCESS","note":"All checks passed successfully"}
{"timestamp":"1733164097","namespace":"required_checks","successes":2,"failures":0,"warnings":0,"result":"SUCCESS","note":"All checks passed successfully"}
{"image": {"pullspec": "quay.io/redhat-user-workloads/kalem-tenant/devfile-sample-python-basic:3fe0848df23095703ded201abf40026a6648330f", "digests": ["sha256:70a9c298dccedbde0dfc3b679807db118cf2152ee63b779f95ca4267828bb0b8"]}}
step-upload

Selecting auth
Using token for quay.io/redhat-user-workloads/kalem-tenant/devfile-sample-python-basic
Attaching to quay.io/redhat-user-workloads/kalem-tenant/devfile-sample-python-basic:3fe0848df23095703ded201abf40026a6648330f
Uploading 4f523535a2d9 clamscan-ec-test-amd64.json
Uploading 0476087e82b1 clamscan-result-amd64.log
Uploaded  4f523535a2d9 clamscan-ec-test-amd64.json
Uploaded  0476087e82b1 clamscan-result-amd64.log
Attached to [registry] quay.io/redhat-user-workloads/kalem-tenant/devfile-sample-python-basic@sha256:70a9c298dccedbde0dfc3b679807db118cf2152ee63b779f95ca4267828bb0b8
Digest: sha256:37ed439a4d59e4959913186258e720344f3badd831607c27863e31369f9d6613

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasemAlem kasemAlem requested a review from jsztuka December 3, 2024 11:43
@kasemAlem kasemAlem force-pushed the STONEINTG-1072-clamav-scan branch from 72daf05 to 8493b5d Compare December 3, 2024 12:27
@kasemAlem kasemAlem requested a review from jsztuka December 3, 2024 12:27
@kasemAlem kasemAlem force-pushed the STONEINTG-1072-clamav-scan branch from 8493b5d to 839c868 Compare December 3, 2024 12:38
Copy link
Contributor

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kasemAlem kasemAlem added this pull request to the merge queue Dec 3, 2024
Merged via the queue into konflux-ci:main with commit 98cd017 Dec 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants