Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(KONFLUX-5971): set intg test status in git according to PR bld PLR #981

Merged
merged 1 commit into from
Jan 17, 2025
Merged

feat(KONFLUX-5971): set intg test status in git according to PR bld PLR #981

merged 1 commit into from
Jan 17, 2025

Conversation

hongweiliu17
Copy link
Contributor

  • set integration tests status to pending when build plr is triggered or retriggered
  • set integration test status to failed/cancelled when build plr fails
  • set integration test status to failed/cancelled with failure reason when snapshot is not created to show to users on git provider

Signed-off-by: Hongwei Liu[email protected]

Maintainers will complete the following section

@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 69.94220% with 52 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@a0ef20f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../controller/buildpipeline/buildpipeline_adapter.go 67.12% 36 Missing and 12 partials ⚠️
status/reporter_github.go 71.42% 2 Missing ⚠️
...ntroller/buildpipeline/buildpipeline_controller.go 0.00% 1 Missing ⚠️
...al/controller/statusreport/statusreport_adapter.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage        ?   64.14%           
=======================================
  Files           ?       49           
  Lines           ?     6253           
  Branches        ?        0           
=======================================
  Hits            ?     4011           
  Misses          ?     1883           
  Partials        ?      359

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hongweiliu17 hongweiliu17 mentioned this pull request Jan 10, 2025
Closed
3 tasks
@kasemAlem
Copy link
Contributor

/test images

dirgim
dirgim reviewed Jan 13, 2025
View reviewed changes
status/status.go Outdated Show resolved Hide resolved
dirgim
dirgim reviewed Jan 13, 2025
View reviewed changes
status/status.go Outdated Show resolved Hide resolved
@hongweiliu17 hongweiliu17 force-pushed the KONFLUX-5971-1 branch 2 times, most recently from 2b728c5 to e80e2c2 Compare January 13, 2025 14:04
@hongweiliu17
Copy link
Contributor Author

/retest

1 similar comment
@dirgim
Copy link
Collaborator

dirgim commented Jan 14, 2025

/retest

@hongweiliu17 hongweiliu17 force-pushed the KONFLUX-5971-1 branch 2 times, most recently from 96355e8 to 791a90b Compare January 14, 2025 13:12
@hongweiliu17
Copy link
Contributor Author

/retest

@hongweiliu17 hongweiliu17 force-pushed the KONFLUX-5971-1 branch 3 times, most recently from b85d061 to 42f7a42 Compare January 15, 2025 10:55
@hongweiliu17
Copy link
Contributor Author

Tested on my cluster. the checkRun with pending status is created when build PLR is triggered and then is set to failed when build PLR fails, example checkRun https://github.com/hongweiliu17/devfile-sample-go-basic-1772/pull/2/checks

@kasemAlem
Copy link
Contributor

/retest

1 similar comment
@hongweiliu17
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot added the lgtm label Jan 16, 2025
dirgim
dirgim approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@hongweiliu17
feat(KONFLUX-5971): set intg test status in git according to PR bld PLR
eb907f5 
* set integration tests status to pending when build plr is triggered or
  retriggered
* set integration test status to failed/cancelled when build plr fails
* set integration test status to failed/cancelled with failure reason
  when snapshot is not created to show to users on git provider

Signed-off-by: Hongwei Liu<[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Jan 16, 2025
@jsztuka
Copy link
Contributor

jsztuka commented Jan 16, 2025

I am wondering what the lifecycle of the temp snapshot is. Can you describe when is it being removed? Is there a possibility that multiple temp snapshots are being created at once?

@hongweiliu17
Copy link
Contributor Author

I am wondering what the lifecycle of the temp snapshot is. Can you describe when is it being removed? Is there a possibility that multiple temp snapshots are being created at once?

This temp snapshot will not be created. It is just one object to save the labels and annotations.

@openshift-ci openshift-ci bot added the lgtm label Jan 16, 2025
@hongweiliu17
Copy link
Contributor Author

/retest

@hongweiliu17 hongweiliu17 merged commit e209637 into konflux-ci:main Jan 17, 2025
12 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Jan 17, 2025
Closed
This was referenced Jan 21, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Everett Josh-Everett Josh-Everett approved these changes

@dirgim dirgim dirgim approved these changes

@kasemAlem kasemAlem kasemAlem approved these changes

@jsztuka jsztuka Awaiting requested review from jsztuka jsztuka is a code owner

@sonam1412 sonam1412 Awaiting requested review from sonam1412 sonam1412 is a code owner

@dheerajodha dheerajodha Awaiting requested review from dheerajodha dheerajodha is a code owner

@14rcole 14rcole Awaiting requested review from 14rcole 14rcole is a code owner

@jencull jencull Awaiting requested review from jencull jencull is a code owner

Assignees

@Josh-Everett Josh-Everett

@dirgim dirgim

@kasemAlem kasemAlem

Labels
lgtm size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hongweiliu17 @codecov-commenter @kasemAlem @dirgim @jsztuka @Josh-Everett