Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CVP-4333): add helper functions for fips operator checks #337

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

yashvardhannanavati
Copy link
Contributor

this commit adds two helper functions named get_image_labels and extract_related_images_from_bundle to avoid code duplicatioin in build-definitions tasks

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@a41245d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #337   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        18           
  Lines           ?       502           
  Branches        ?         0           
========================================
  Hits            ?       502           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yashvardhannanavati yashvardhannanavati force-pushed the unreleased_bundle branch 2 times, most recently from eab52d1 to 9fe2c8f Compare December 7, 2024 11:49
@yashvardhannanavati
Copy link
Contributor Author

@dirgim @arewm Could you please take a look?

test/utils.sh Outdated Show resolved Hide resolved
this commit adds two helper functions named get_image_labels and
extract_related_images_from_bundle to avoid code duplicatioin
in build-definitions tasks

Signed-off-by: Yashvardhan Nanavati <[email protected]>
Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirgim dirgim merged commit c8d0e6d into konflux-ci:main Dec 10, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants