feat(CVP-4395,CVP-4396): add get package, channel and highest bundle functions in utils #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 18
Lines ? 502
Branches ? 0
========================================
Hits ? 502
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
asergienk
force-pushed
the
get_package_name
branch
4 times, most recently
from
769c61b to
2917951
Compare
dirgim
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
LGTM code-wise, but the gitlint issues will need to be addressed to unblock this:
1: CC1 Body does not contain a 'Signed-off-by' line
3: B6 Body message is missing
|
@dirgim I added a "Signed-off-by" line, and I have a "body message". I think the gitlink checks should pass now. Could you please re-run the ci tests? |
|
@asergienk You need to add the 'Signed-off-by' line and body message within your commit message. |
asergienk
force-pushed
the
get_package_name
branch
from
2917951 to
767338d
Compare
jsztuka
reviewed
Jan 28, 2025
asergienk
force-pushed
the
get_package_name
branch
from
767338d to
4f6ca67
Compare
|
@dheerajodha thank you so much for the clarification and the example! I signed my commit and added a body message to it. |
asergienk
force-pushed
the
get_package_name
branch
from
4f6ca67 to
8a0b759
Compare
dirgim
requested review from
14rcole,
Josh-Everett,
hongweiliu17,
kasemAlem,
dheerajodha,
sonam1412,
jsztuka and
jencull
This commit adds two functions: *get_package_from_catalog: Given an output of opm render fbcFragment, it returns a package. *get_channel_from_catalog: Given an output of opm render fbcFragment and a olm.package, it returns the 'defaultChannel' value from the olm.package entry *get_highest_bundle_version: Given an output of opm render fbcFragment, package and channel, returns the highest bundle version **All functions will be used in the tasks of deploy-fbc pipeline in tekton-integration-catalog Signed-off-by: Anna Rania <[email protected]>
asergienk
force-pushed
the
get_package_name
branch
from
8a0b759 to
5e6ed80
Compare
asergienk
changed the title
|
/ok-to-test |
dheerajodha
reviewed
Jan 29, 2025
dheerajodha
approved these changes
Jan 30, 2025
|
/ok-to-test |
|
/retest |
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two functions:
All functions will be used in the task of a 'deploy-fbc' pipeline in https://github.com/konflux-ci/tekton-integration-catalog
Signed-off-by: asergienk [email protected]