chore(KFLUXUI-296): remove workspace dependency from Components #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoaoPedroPP
force-pushed
the
KFLUXUI-296
branch
3 times, most recently
from
a183e08 to
eb63f5f
Compare
sahil143
requested changes
Feb 10, 2025
| const applicationBreadcrumbs = useApplicationBreadcrumbs(); | ||
| const showModal = useModalLauncher(); | ||
| const [component, loaded, componentError] = useComponent(namespace, workspace, componentName); | ||
| const [component, loaded, componentError] = useComponent(namespace, workspaceName, componentName); |
There was a problem hiding this comment.
we need to remove the usage of workspace. No need to get it from route params. that will be removed later.
There was a problem hiding this comment.
Removed in new version.
| const customizePipeline = () => { | ||
| track(TrackEvents.ButtonClicked, { | ||
| link_name: 'manage-build-pipeline', | ||
| link_location: 'component-list-label', | ||
| component_name: component.metadata.name, | ||
| app_name: component.spec.application, | ||
| workspace, | ||
| workspace: workspaceName, |
There was a problem hiding this comment.
I replaced by namespace, is it correct?
| const track = useTrackEvent(); | ||
| const showModal = useModalLauncher(); | ||
| const [component] = useComponent(namespace, workspace, componentName); | ||
| const [component] = useComponent(namespace, workspaceName, componentName); |
There was a problem hiding this comment.
Removed in new version.
| @@ -101,7 +104,11 @@ const ComponentLatestBuild: React.FC<React.PropsWithChildren<ComponentLatestBuil | |||
| {commit ? ( | |||
| <> | |||
| <Link | |||
| to={`/workspaces/${workspace}/applications/${commit.application}/commit/${commit.sha}`} | |||
| to={COMMIT_DETAILS_PATH.createPath({ | |||
| workspaceName, | |||
There was a problem hiding this comment.
All occurrences of workspaceName in a createPath function are now workspaceName: namespace
src/routes/utils.ts
Outdated
| @@ -8,6 +8,7 @@ export const RouterParams = { | |||
| taskRunName: 'taskRunName', | |||
| componentName: 'componentName', | |||
| commitName: 'commitName', | |||
| commitSha: 'commitSha', | |||
There was a problem hiding this comment.
We use commitName as the commitSha
There was a problem hiding this comment.
Thanks Sahil! I deleted commitSha and replace its use by commitName
|
if these changes are correct then I will adjust the unit tests |
JoaoPedroPP
force-pushed
the
KFLUXUI-296
branch
from
e80a549 to
1c25dbd
Compare
JoaoPedroPP
force-pushed
the
KFLUXUI-296
branch
from
1c25dbd to
baa6680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
KFLUXUI-296
Description
WIP: Just replace workspace for namespace
Type of change
Screen shots / Gifs for design review
Browser conformance: