Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mark workspace hooks and utils deprecated #111

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

sahil143
Copy link
Collaborator

Fixes

Marks workspace usage in Ui deprecated

Description

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

No visual changes

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 68.08511% with 15 lines in your changes missing coverage. Please review.

Project coverage is 79.95%. Comparing base (591f649) to head (e4a87a2).

Files with missing lines Patch % Lines
src/components/Workspace/utils.ts 50.00% 9 Missing and 1 partial ⚠️
src/components/Workspace/index.ts 0.00% 3 Missing ⚠️
src/components/Workspace/workspace-context.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   80.10%   79.95%   -0.15%     
==========================================
  Files         577      577              
  Lines       21495    21519      +24     
  Branches     5064     5065       +1     
==========================================
- Hits        17219    17206      -13     
- Misses       4252     4289      +37     
  Partials       24       24              
Flag Coverage Δ
unittests 79.95% <68.08%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JoaoPedroPP JoaoPedroPP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UI is working properly. I have only one question above, but don't want delay this.

@sahil143 sahil143 merged commit fc997b2 into konflux-ci:main Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants