-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(KONFLUX-5956): ensure optional username and mandatory password for secret form #112
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage 80.07% 80.07%
=======================================
Files 544 544
Lines 21179 21179
Branches 5327 5327
=======================================
Hits 16960 16960
- Misses 4194 4195 +1
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
/test |
@@ -49,10 +49,6 @@ export const secretFormValidationSchema = yup.object({ | |||
is: SecretTypeDropdownLabel.source, | |||
then: yup.object({ | |||
authType: yup.string(), | |||
username: yup.string().when('authType', { | |||
is: SourceSecretType.basic, | |||
then: yup.string().required('Required'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only remove the required method from the validation
How about change the title to something like 'ensure optional username and mandatory password'? |
@testcara Could you please let me know if we need to make this username optional? |
/test |
Fixes
https://issues.redhat.com/browse/KONFLUX-5956
Description
removed required for username and added * for password
Type of change
Screen shots / Gifs for design review
How to test or reproduce?
Browser conformance: