chore(KFLUXUI-279): replace Workspace by Namespace only in the UI #94
+25
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
========================================
Coverage 80.14% 80.14%
========================================
Files 570 570
Lines 21536 21536
Branches 5076 5332 +256
========================================
Hits 17260 17260
+ Misses 4251 4250 -1
- Partials 25 26 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I searched in other places of the UI but apparently this is the only place beside the Workspace switcher, that should have another story. |
JoaoPedroPP
force-pushed
the
KFLUXUI-279
branch
3 times, most recently
from
16011d6 to
7993236
Compare
|
Would any of these qualify for an update?
|
JoaoPedroPP
force-pushed
the
KFLUXUI-279
branch
2 times, most recently
from
51ca090 to
f93a288
Compare
They certainly qualify! Thanks for the close look @CryptoRodeo :) Code updated |
JoaoPedroPP
force-pushed
the
KFLUXUI-279
branch
from
f93a288 to
962e31d
Compare
JoaoPedroPP
force-pushed
the
KFLUXUI-279
branch
from
962e31d to
129429b
Compare
JoaoPedroPP
force-pushed
the
KFLUXUI-279
branch
from
6e559e7 to
bdc4759
Compare
| @@ -48,7 +48,7 @@ const NoAccessState: React.FC<React.PropsWithChildren<NoAccessStateProps>> = ({ | |||
| /> | |||
| <EmptyStateBody> | |||
| {body || | |||
| `Ask the administrator or the owner of the ${workspace} workspace for access permissions.`} | |||
| `Ask the administrator or the owner of the ${workspace} namespace for access permissions.`} | |||
There was a problem hiding this comment.
Change the variable as well. It does not make sense otherwise.
| @@ -24,7 +24,7 @@ const EditAccessPage: React.FC<React.PropsWithChildren<unknown>> = () => { | |||
| ? [{ model: SpaceBindingRequestModel, verb: 'update' }] | |||
| : [{ model: SpaceBindingRequestModel, verb: 'create' }]; | |||
|
|
|||
| useDocumentTitle(`Edit access to workspace, ${workspace} | ${FULL_APPLICATION_TITLE}`); | |||
| useDocumentTitle(`Edit access to namespace, ${workspace} | ${FULL_APPLICATION_TITLE}`); | |||
| @@ -29,12 +29,12 @@ export const UserAccessForm: React.FC<React.PropsWithChildren<Props>> = ({ | |||
| return ( | |||
| <PageLayout | |||
| title={ | |||
| edit ? `Edit access to workspace, ${workspace}` : `Grant access to workspace, ${workspace}` | |||
| edit ? `Edit access to namespace, ${workspace}` : `Grant access to namespace, ${workspace}` | |||
| @@ -43,14 +43,14 @@ const UserAccessEmptyState: React.FC< | |||
| title="Grant user access" | |||
| > | |||
| <EmptyStateBody> | |||
| See a list of all the users that have access to your workspace. | |||
| See a list of all the users that have access to your namespace. | |||
| </EmptyStateBody> | |||
| <EmptyStateActions> | |||
| <ButtonWithAccessTooltip | |||
| variant="primary" | |||
| component={(props) => <Link {...props} to={`/workspaces/${workspace}/access/grant`} />} | |||
There was a problem hiding this comment.
should not it be changed in link as well?
There was a problem hiding this comment.
According to @sahil143 there will be a future ticket only to remove this kind of mention
| @@ -120,7 +120,7 @@ export const UserAccessListView: React.FC<React.PropsWithChildren<unknown>> = () | |||
| <Link {...props} to={`/workspaces/${workspace}/access/grant`} /> | |||
StanislavJochman
previously approved these changes
Feb 3, 2025
JoaoPedroPP
force-pushed
the
KFLUXUI-279
branch
2 times, most recently
from
6e559e7 to
02228b8
Compare
JoaoPedroPP
force-pushed
the
KFLUXUI-279
branch
from
02228b8 to
c6c4a9f
Compare
StanislavJochman
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
KFLUXUI-279
Description
Replace all occurrences of
Workspacein UI byNamespaceType of change
Screen shots / Gifs for design review
Current
After change
Browser conformance: