Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHTAPREL-816): add translate-delivery-repo utility #117

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

johnbieren
Copy link
Collaborator

This commit adds the translate-delivery-repo to translate quay.io/redhat-prod/product----repo into registry.redhat.io/product/repo and quay.io/redhat-pending/product----repo into
registry.stage.redhat.io/product/repo. This translation will need to be done in multiple places, so it should be stored as a utility in this image instead of repeating the logic in multiple locations.

@johnbieren johnbieren requested a review from a team as a code owner February 2, 2024 16:02
Copy link
Contributor

@mmalina mmalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not against this. But I'm wondering about the multiple places where this will be used. Can you elaborate?

Because from what I know, currently we need this in one place. And then something similar for the Pyxis repo object, but that one is slightly different - that one uses registry.access.redhat.com.

@johnbieren
Copy link
Collaborator Author

I am not against this. But I'm wondering about the multiple places where this will be used. Can you elaborate?

Because from what I know, currently we need this in one place. And then something similar for the Pyxis repo object, but that one is slightly different - that one uses registry.access.redhat.com.

It is currently in the rh-sign-image and sign-index-image task. So that is already multiple places. It also needs to be used in https://issues.redhat.com/browse/RHTAPREL-793

@mmalina
Copy link
Contributor

mmalina commented Feb 5, 2024

It is currently in the rh-sign-image and sign-index-image task. So that is already multiple places. It also needs to be used in https://issues.redhat.com/browse/RHTAPREL-793

Thanks. I guess I didn't know about the sign index image task (could have looked, yeah :) )

This commit adds the translate-delivery-repo to translate
quay.io/redhat-prod/product----repo into registry.redhat.io/product/repo
and quay.io/redhat-pending/product----repo into
registry.stage.redhat.io/product/repo. This translation will need to be
done in multiple places, so it should be stored as a utility in this
image instead of repeating the logic in multiple locations.

Signed-off-by: Johnny Bieren <[email protected]>
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@johnbieren johnbieren merged commit 0e10491 into konflux-ci:main Feb 6, 2024
7 checks passed
@johnbieren johnbieren deleted the rhtaprel_816 branch February 6, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants