Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify authenticateUser to handle the new callbacks. #48

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joefresco
Copy link

This was written as a fix for: #45
amazon-cognito-identity-js changed in late 2016 to use a different callback instead of reusing "success". That broke vue-auth-cognito.

Add completeNewPasswordChallenge for users created by the admin so users can set their password and be logged in.
Required adding lodash.clonedeep to persist the cognitoUser object. I couldn't find any other way to reuse the cognitoUser object "elegently."

I did reuse the userConfirmationNecessary flag that already existed, though this will still require modifying any code that would have used the old code.

This implementation is still missing

  1. Unit tests
  2. Documentation on using it
  3. mfaRequired handling, which we aren't using. I added the stub for it.

I also left a lot of comments in the code from the documentation.

Add completeNewPasswordChallenge for users created by the admin so users can set their password and be logged in.
Required adding lodash.clonedeep to persist the cognitoUser object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants