onReady for resolveURL #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2016 13:46
|
@sbauch looks solid! Please add docs 👍 |
|
@voronianski thanks! docs added. |
|
I'd love to add us, but we're using this in a piece of private internal software at WeWork in the UX group. |
|
could we possibly release a new version of the package that has this work included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to know when a track was ready to be played so that I could programmatically start playing it, so I added this
onReadyprop.Happy to write docs / examples, but wanted to run the approach by the maintainers first.
thanks for this component, super handy!