#164 add_display_name #164 #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshkhandeparkar
requested changes
Dec 9, 2023
.githooks/pre-commit
Outdated
There was a problem hiding this comment.
Why was this file changed?
There was a problem hiding this comment.
Din't make any changes in this file. It got deleted so just added with same code.
There was a problem hiding this comment.
File permission seems to have changed. Can you revert this change?
|
Have you tested this locally? |
|
@ank1traj are you still working on this? If yes, please make the requested changes and reply to my questions. Thanks! |
Couldn't able to check due to the laptop constraints. And, sorry for missing out the above message. Didn't get the notifications before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Title: Add display_name field to student and mentor models
PR Description:
This PR adds a
display_namefield to student and mentor models. This field will be displayed on the website and in statistics while thenamefield will be printed on the certificate.Changes:
display_namefield to theStudentandMentormodels.Benefits:
display_nameandnamefields when printing certificates.