Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kantis/explicit action threads #307

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Kantis/explicit action threads #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97a81a0
Updating since-build to oldest targeted version
Kantis Jun 21, 2024
eefdd91
Explicitly specify thread for Kotest toolbar actions
Kantis Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/kotlin/io/kotest/plugin/intellij/toolwindow/toolbar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package io.kotest.plugin.intellij.toolwindow
import com.intellij.icons.AllIcons
import com.intellij.openapi.actionSystem.ActionManager
import com.intellij.openapi.actionSystem.ActionPlaces
import com.intellij.openapi.actionSystem.ActionUpdateThread
import com.intellij.openapi.actionSystem.AnAction
import com.intellij.openapi.actionSystem.AnActionEvent
import com.intellij.openapi.actionSystem.DefaultActionGroup
Expand Down Expand Up @@ -53,6 +54,8 @@ class ExpandAllAction(private val tree: TestFileTree) : AnAction("Expand All", n
class FilterCallbacksAction(private val tree: TestFileTree) :
ToggleAction("Filter Vallbacks", null, AllIcons.Nodes.Controller) {

override fun getActionUpdateThread() = ActionUpdateThread.EDT

override fun isSelected(e: AnActionEvent): Boolean {
return TestExplorerState.showCallbacks
}
Expand All @@ -66,6 +69,8 @@ class FilterCallbacksAction(private val tree: TestFileTree) :
class FilterModulesAction(private val tree: TestFileTree) :
ToggleAction("Filter Modules", null, AllIcons.Nodes.ModuleGroup) {

override fun getActionUpdateThread() = ActionUpdateThread.EDT

override fun isSelected(e: AnActionEvent): Boolean {
return TestExplorerState.showModules
}
Expand All @@ -77,6 +82,7 @@ class FilterModulesAction(private val tree: TestFileTree) :
}

class FilterTagsAction(private val tree: TestFileTree) : ToggleAction("Filter Tags", null, AllIcons.Nodes.Tag) {
override fun getActionUpdateThread() = ActionUpdateThread.EDT

override fun isSelected(e: AnActionEvent): Boolean {
return TestExplorerState.showTags
Expand All @@ -89,6 +95,7 @@ class FilterTagsAction(private val tree: TestFileTree) : ToggleAction("Filter Ta
}

class FilterIncludesAction(private val tree: TestFileTree) : ToggleAction("Filter Includes", null, AllIcons.Nodes.Tag) {
override fun getActionUpdateThread() = ActionUpdateThread.EDT

override fun isSelected(e: AnActionEvent): Boolean {
return TestExplorerState.showIncludes
Expand All @@ -105,6 +112,7 @@ class NavigateToNodeAction : ToggleAction(
null,
AllIcons.General.AutoscrollToSource
) {
override fun getActionUpdateThread() = ActionUpdateThread.EDT

override fun isSelected(e: AnActionEvent): Boolean {
return TestExplorerState.autoscrollToSource
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/META-INF/plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<!-- correct values will be set by the build plugin -->
<version>1.0.0</version>
<idea-version since-build="211.6085.26"/>
<idea-version since-build="223.4884.69"/>

<depends>org.jetbrains.kotlin</depends>
<depends>com.intellij.modules.java</depends>
Expand Down