Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kantis/service refactor #308

Merged
merged 11 commits into from
Jun 25, 2024
Merged

Kantis/service refactor #308

merged 11 commits into from
Jun 25, 2024

Conversation

Kantis
Copy link
Member

@Kantis Kantis commented Jun 22, 2024 •
edited
Loading

Builds on #305 and #307

Extracts all state into a Service as recommended in the guidelines.

Running scans and stuff on background thread.

@Kantis Kantis force-pushed the kantis/service-refactor branch from cadb1dd to c472c12 Compare June 22, 2024 10:23
@Kantis Kantis force-pushed the kantis/service-refactor branch from 76a3dbb to eb84e19 Compare June 22, 2024 19:54
@Kantis
Copy link
Member Author

Kantis commented Jun 22, 2024 •
edited
Loading

Seems like Services using coroutines aren't supported for IC-223... Not sure if we can drop that version as well?

edit: I figured a way around it for 223.. but would be nice to get rid of workarounds later.

@Kantis Kantis marked this pull request as ready for review June 22, 2024 22:17
@Kantis Kantis requested a review from sksamuel June 24, 2024 13:46
@sksamuel
Copy link
Member

Seems like Services using coroutines aren't supported for IC-223... Not sure if we can drop that version as well?

edit: I figured a way around it for 223.. but would be nice to get rid of workarounds later.

223 is still pretty popular, should keep it for remainder of 2024 I'd say

@Kantis
Copy link
Member Author

Kantis commented Jun 25, 2024

Seems like Services using coroutines aren't supported for IC-223... Not sure if we can drop that version as well?
edit: I figured a way around it for 223.. but would be nice to get rid of workarounds later.

223 is still pretty popular, should keep it for remainder of 2024 I'd say

Alright 👍🏼 are there stats for the versions somewhere?

@Kantis Kantis merged commit 2a4c933 into master Jun 25, 2024
5 checks passed
@Kantis Kantis deleted the kantis/service-refactor branch June 25, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sksamuel sksamuel sksamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kantis @sksamuel