fix(api): avoid division by zero in list size (#315)

kouprlabs · Sep 7, 2024 · 5c9dc8a · 5c9dc8a
1 parent 5a465ec
commit 5c9dc8a
Show file tree

Hide file tree

Showing 9 changed files with 30 additions and 0 deletions.
diff --git a/api/router/file_router.go b/api/router/file_router.go
@@ -360,6 +360,9 @@ func (r *FileRouter) List(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")

diff --git a/api/router/group_router.go b/api/router/group_router.go
@@ -129,6 +129,9 @@ func (r *GroupRouter) List(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")

diff --git a/api/router/insights_router.go b/api/router/insights_router.go
@@ -183,6 +183,9 @@ func (r *InsightsRouter) ListEntities(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")

diff --git a/api/router/invitation_router.go b/api/router/invitation_router.go
@@ -107,6 +107,9 @@ func (r *InvitationRouter) GetIncoming(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")
@@ -184,6 +187,9 @@ func (r *InvitationRouter) GetOutgoing(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")

diff --git a/api/router/organization_router.go b/api/router/organization_router.go
@@ -187,6 +187,9 @@ func (r *OrganizationRouter) List(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")

diff --git a/api/router/snapshot_router.go b/api/router/snapshot_router.go
@@ -84,6 +84,9 @@ func (r *SnapshotRouter) List(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")

diff --git a/api/router/task_router.go b/api/router/task_router.go
@@ -106,6 +106,9 @@ func (r *TaskRouter) List(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")

diff --git a/api/router/user_router.go b/api/router/user_router.go
@@ -72,6 +72,9 @@ func (r *UserRouter) List(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")

diff --git a/api/router/workspace_router.go b/api/router/workspace_router.go
@@ -126,6 +126,9 @@ func (r *WorkspaceRouter) List(c *fiber.Ctx) error {
 			return err
 		}
 	}
+	if size == 0 {
+		return errorpkg.NewInvalidQueryParamError("size")
+	}
 	sortBy := c.Query("sort_by")
 	if !IsValidSortBy(sortBy) {
 		return errorpkg.NewInvalidQueryParamError("sort_by")