Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make all packages unique and resolvable #133

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

dsonck92
Copy link
Collaborator

@dsonck92 dsonck92 commented Jul 9, 2024

  • Create a workspace for the monorepo
  • Rename all modules to be unique and matching their import paths. This is a preparation for enabling gci sorting later on

dsonck92 and others added 2 commits July 9, 2024 20:21
- Create a workspace for the monorepo
- Rename all modules to be unique and matching their import paths
  This is a preparation for enabling gci sorting later on
@dsonck92
Copy link
Collaborator Author

dsonck92 commented Jul 9, 2024

This makes all the projects able to be pulled in as library as well (I just verified this with a local project). This will help down the line with the rclone "Voltaserve" backend idea by writing a client in this monorepo for other projects to consume.

@dsonck92 dsonck92 marked this pull request as ready for review July 9, 2024 18:40
@dsonck92 dsonck92 requested a review from bouassaba July 9, 2024 18:48
@dsonck92
Copy link
Collaborator Author

dsonck92 commented Jul 9, 2024

And of course, this way we can also get more code reuse by services using common files. For instance, the Mosaic service may define its own API data objects, and the API can utilize these

@dsonck92 dsonck92 merged commit 6cd9ff9 into main Jul 9, 2024
12 checks passed
@bouassaba bouassaba deleted the chore/fix-module-names branch October 30, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants